Baremetal / Add stork consul scenario #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjgg
force-pushed
the
feat/stork-consul
branch
2 times, most recently
from
09c96ed to
e2cff3e
Compare
pjgg
changed the title
fedinskiy
requested changes
Mar 16, 2022
service-discovery/stork-consul/src/main/java/io/quarkus/ts/stork/PongReplicaResource.java
Outdated
Show resolved
Hide resolved
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
fedinskiy
requested changes
Mar 16, 2022
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
service-discovery/stork-consul/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
pjgg
force-pushed
the
feat/stork-consul
branch
4 times, most recently
from
cd59788 to
e0bfe65
Compare
pjgg
force-pushed
the
feat/stork-consul
branch
2 times, most recently
from
aff2e78 to
0efc8f3
Compare
fedinskiy
reviewed
Mar 21, 2022
| public void init(@Observes StartupEvent ev, Vertx vertx) { | ||
| if (serviceDiscoveryType.equalsIgnoreCase("consul")) { | ||
| ConsulClient client = ConsulClient.create(vertx, | ||
| new ConsulClientOptions().setHost(host).setPort(Integer.parseInt(port))); |
There was a problem hiding this comment.
this.port, if you don't mind. Also, can't we have integer ConfigProperties?
| } catch (IOException e) { | ||
| fail("no free port available."); | ||
| } | ||
| return String.valueOf(-1); |
There was a problem hiding this comment.
Will Quarkus handle such port number properly?
fedinskiy
requested changes
Mar 21, 2022
service-discovery/stork/src/test/java/io/quarkus/ts/stork/StorkServiceDiscoveryIT.java
Outdated
Show resolved
Hide resolved
| public void init(@Observes StartupEvent ev, Vertx vertx) { | ||
| if (serviceDiscoveryType.equalsIgnoreCase("consul")) { | ||
| ConsulClient client = ConsulClient.create(vertx, | ||
| new ConsulClientOptions().setHost(host).setPort(Integer.parseInt(port))); |
There was a problem hiding this comment.
Here, and everywhere in Resources:
Suggested change
| new ConsulClientOptions().setHost(host).setPort(Integer.parseInt(port))); | |
| new ConsulClientOptions().setHost(host).setPort(Integer.parseInt(this.port))); |
There was a problem hiding this comment.
Let's keep it as it's other modules. there is no a team agreement about that
There was a problem hiding this comment.
Currently, we are following this principle: https://checkstyle.sourceforge.io/config_coding.html#RequireThis
But is true that is not added to checkstyle template
<module name="RequireThis">
<property name="validateOnlyOverlapping" value="true"/>
</module>
- default service discovery - default load balncer
fedinskiy
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies Stork-consul integration in order to provide service discovering and round-robin load balancing between services
StorkServiceDiscoveryITscenario deploys four services:pungandpong(Pong and PongReplica) services. The servicediscovery will be done by Stork, and the request dispatching between "pong" services is going to be done by Stork load balancer.
Test Plan coverage
Reported issues:
Missing stork quarkus properties: quarkusio/quarkus#24341
Service discovery expiration time: quarkusio/quarkus#24343